On Wed, 20 Jan 2021, Hans de Goede wrote:
The (shared) probing code of the arizona-i2c and arizona-spi modules takes the following steps during init:
- Call mfd_add_devices() for a set of early child-devices, this
includes the arizona_ldo1 device which provides one of the core-regulators.
Bulk enable the core-regulators.
Read the device id.
Call mfd_add_devices() for the other child-devices.
This sequence depends on 1. leading to not only the child-device being created, but also the driver for the child-device binding to it and registering its regulator.
This requires the arizona_ldo1 driver to be loaded before the shared probing code runs. Add a softdep for this to both modules to ensure that this requirement is met.
Note this mirrors the existing MODULE_SOFTDEP("pre: wm8994_regulator") in the wm8994 code, which has a similar init sequence.
Reviewed-by: Andy Shevchenko andy.shevchenko@gmail.com Acked-by: Charles Keepax ckeepax@opensource.cirrus.com Signed-off-by: Hans de Goede hdegoede@redhat.com
drivers/mfd/arizona-i2c.c | 1 + drivers/mfd/arizona-spi.c | 1 + 2 files changed, 2 insertions(+)
Applied, thanks.