Re: [alsa-devel] [RFC 02/16] ASoC: multi-component - cs4720, cs42l51 and da7210 CODECs

On Fri, 2010-06-25 at 13:29 -0500, Timur Tabi wrote:

On Fri, Jun 25, 2010 at 12:52 PM, Liam Girdwood lrg@slimlogic.co.uk wrote:

...

/* Private data for the CS4270 */ struct cs4270_private {

•   struct snd_soc_codec codec;
  

•   enum snd_soc_control_type control_type;
  

•   void *control_data;
  

Because of this change, there is a comment later in the file that is no longer valid:

/* Allocate enough space for the snd_soc_codec structure and our private data together. */ cs4270 = kzalloc(sizeof(struct cs4270_private), GFP_KERNEL); if (!cs4270) { dev_err(&i2c_client->dev, "could not allocate codec\n"); return -ENOMEM; }

Other than that ...

CS4270 portions: Acked-by: Timur Tabi timur@freescale.com

Thanks, fixed.

Liam