Re: [PATCH] ASoC: rt5682: Properly turn off regulators if wrong device ID

Hi,

On Tue, Aug 10, 2021 at 9:24 PM Stephen Boyd swboyd@chromium.org wrote:

...

@@ -156,6 +163,10 @@ static int rt5682_i2c_probe(struct i2c_client *i2c, dev_err(&i2c->dev, "Failed to request supplies: %d\n", ret); return ret; }

Nit: Add newline here.

How strongly do you feel about it? I purposely left the newline off to try to tie the devm_add_action_or_reset() more closely to the devm_regulator_bulk_get(). I wanted to make it more obvious that the two of them were "together" and shouldn't be split up. That being said, it's no skin off my teeth to add a newline if everyone likes it better. ;-)

...

•   ret = devm_add_action_or_reset(&i2c->dev, rt5682_i2c_disable_regulators,
  

•                                  rt5682);
  

•   if (ret)
  

•           return ret;