Hi Andy,
Thanks for your feedback.
From: Andy Shevchenko andriy.shevchenko@linux.intel.com Sent: 18 April 2024 19:56 To: Xu, Baojun Cc: tiwai@suse.de; robh+dt@kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre-louis.bossart@linux.intel.com; Lu, Kevin; Ding, Shenghao; Navada Kanyana, Mukund; 13916275206@139.com; P O, Vijeth; Holalu Yogendra, Niranjan; alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; liam.r.girdwood@intel.com; yung-chuan.liao@linux.intel.com; broonie@kernel.org; soyer@irl.hu Subject: [EXTERNAL] Re: [PATCH v3 1/3] ALSA: hda/tas2781: Modification for add tas2781 driver for SPI
On Thu, Apr 18, 2024 at 12: 02: 37PM +0800, Baojun Xu wrote: > Integrate tas2781 configs for HP Laptops. Every tas2781 in the laptop > will work as a single speaker on SPI bus. The code support realtek as Realtek > the primary codec. ZjQcmQRYFpfptBannerStart This message was sent from outside of Texas Instruments. Do not click links or open attachments unless you recognize the source of this email and know the content is safe. If you wish to report this message to IT Security, please forward the message as an attachment to phishing@list.ti.com
ZjQcmQRYFpfptBannerEnd
On Thu, Apr 18, 2024 at 12:02:37PM +0800, Baojun Xu wrote:
Integrate tas2781 configs for HP Laptops. Every tas2781 in the laptop will work as a single speaker on SPI bus. The code support realtek as
Realtek
the primary codec.
...
sound/pci/hda/Kconfig | 15 +++++++++++++++ sound/pci/hda/Makefile | 2 ++
Is this correct? You are adding a dead "code", isn't it?
What's mean "dead code"? After add CONFIG_SND_HDA_SCODEC_TAS2781_SPI=m in my config file, the whole patch code has worked.
...
The rest LGTM.
-- With Best Regards, Andy Shevchenko
Best Regards Jim