On Wed, May 21, 2014 at 4:28 PM, Tomasz Figa t.figa@samsung.com wrote:
Hi Vasily,
Hi Tomasz,
Please remember to keep linux-samsung-soc ML on Cc when sending patches related to Samsung platforms. It is essential to let Samsung people review them.
Ok, I'll keep it in mind. I've just checked and get_maintainer.pl outputs linux-samsung-soc ML for these patches. I've omitted it occasionally, because it wasn't necessary to keep it in CC back in 2011 (year of my last sound-related patch for s3c24xx).
Please resend the series with this in mind.
Is it really necessary? This patch is supposed to go through ASoC tree, not through Samsung's. And I really doubt that Samsung guys test kernel for s3c24xx boards nowadays.
The patch in general looks good to me. Might be a good idea to specify on what board(s) and how it was tested, though.
It was tested on s3c2410-based iPAQ h1940, s3c2412 part was only compile-tested, as I don't have s3c2412 hardware.
Best regards, Tomasz
Regards Vasily