On Thu, Aug 15, 2024 at 11:08:58AM +0200, Takashi Iwai wrote:
On Sat, 27 Jul 2024 10:50:48 +0200, Baojun Xu wrote:
This patch was used to add TAS2781 devices on SPI support in sound/pci/hda. It use ACPI node descript about parameters of TAS2781 on SPI, it like: Scope (_SB.PC00.SPI0) { Device (GSPK) { Name (_HID, "TXNW2781") // _HID: Hardware ID Method (_CRS, 0, NotSerialized) { Name (RBUF, ResourceTemplate () { SpiSerialBusV2 (...) SpiSerialBusV2 (...) } } } }
And in platform/x86/serial-multi-instantiate.c, those spi devices will be added into system as a single SPI device, so TAS2781 SPI driver will probe twice for every single SPI device. And driver will also parser mono DSP firmware binary and RCA binary for itself. The code support Realtek as the primary codec. In patch version-10, add multi devices firmware binary support, to compatble with windows driver, they can share same firmware binary.
Now it's v11, and I'd love to move this forward finally, instead of hanging forever.
The HD-audio part looks more or less OK, but I'd need acks for the ACPI and serial-multi-instance parts below.
Put ACPI and serial-multi-instance maintainers to Cc. Rafael, Hans, let me know if that looks OK to take.
FWIW, the ACPI ID part is legit, if the requirement to include it to those tables, it looks good.