Re: [PATCH 7/7] ASoC: dt-bindings: mediatek,mt79xx-afe: add audio afe document

On 12/06/2023 12:52, Maso Hunag wrote:

From: Maso Huang maso.huang@mediatek.com

Add mt79xx audio afe document.

Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

Signed-off-by: Maso Huang maso.huang@mediatek.com

.../bindings/sound/mediatek,mt79xx-afe.yaml | 102 ++++++++++++++++++ 1 file changed, 102 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt79xx-afe.yaml

diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt79xx-afe.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt79xx-afe.yaml new file mode 100644 index 000000000000..11ef1cfdf49b --- /dev/null +++ b/Documentation/devicetree/bindings/sound/mediatek,mt79xx-afe.yaml @@ -0,0 +1,102 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/mediatek,mt79xx-afe.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: MediaTek AFE PCM controller for MT79xx

79XX sounds weird. Are you sure you are not using wildcards (which are not allowed)?

+maintainers:

• • Maso Huang maso.huang@mediatek.com

+properties:

• compatible:
• oneOf:

•  - const: mediatek,mt79xx-afe
  

•  - items:
  

•      - enum:
  

•          - mediatek,mt7981-afe
  

•          - mediatek,mt7986-afe
  

•          - mediatek,mt7988-afe
  

•      - const: mediatek,mt79xx-afe
  

I already saw AFE, why it cannot be part of existing bindings?

This list is odd. 79xx, 7981? So it is wildcard?

• reg:
• maxItems: 1
• interrupts:
• maxItems: 1
• clocks:
• minItems: 5
• items:

•  - description: audio bus clock
  

•  - description: audio 26M clock
  

•  - description: audio intbus clock
  

•  - description: audio hopping clock
  

•  - description: audio pll clock
  

•  - description: mux for pcm_mck
  

•  - description: audio i2s/pcm mck
  

• clock-names:
• minItems: 5
• items:

•  - const: aud_bus_ck
  

•  - const: aud_26m_ck
  

•  - const: aud_l_ck
  

•  - const: aud_aud_ck
  

•  - const: aud_eg2_ck
  

•  - const: aud_sel
  

•  - const: aud_i2s_m
  

Why this is variable?

• assigned-clocks:
• minItems: 3
• maxItems: 4

Drop assigned-clocks

• assigned-clock-parents:
• minItems: 3
• maxItems: 4

Drop

Best regards, Krzysztof