Re: [alsa-devel] [PATCH] ALSA driver for SGI O2 audio board

10 Jul 2008

      At Wed, 9 Jul 2008 19:50:59 +0200,
Thomas Bogendoerfer wrote:
...
On Mon, Jul 07, 2008 at 05:57:06PM +0200, Takashi Iwai wrote:
...
...

/* allocate IRQs */
for (i = 0; i < ARRAY_SIZE(snd_sgio2_isr_table); i++) {
if (request_irq(snd_sgio2_isr_table[i].irq,

		snd_sgio2_isr_table[i].isr,

		IRQF_SHARED,

		snd_sgio2_isr_table[i].desc,

		&chip->channel[snd_sgio2_isr_table[i].idx])) {

	snd_sgio2audio_free(chip);

	printk(KERN_ERR "sgio2audio: cannot allocate irq %d\n",

	       snd_sgio2_isr_table[i].irq);

	return -EBUSY;

}

}

If there are shared interrupts, they could be called before the
initialization below.  So, safer to move after the init.
they can't be shared and it's already done before any hardware init.
Then any reason to pass IRQF_SHARED?
Takashi