On Mon, 30 Sep 2024 12:50:39 +0200, Oder Chiou wrote:
The headset push button cannot work properly in case of the ALC257. This patch reverted the previous commit to correct the side effect.
Fixes: ef9718b3d54e ("ALSA: hda/realtek: Fix noise from speakers on Lenovo IdeaPad 3 15IAU7") Signed-off-by: Oder Chiou oder_chiou@realtek.com
As it's a regression, the revert is fine. Now applied to for-linus branch.
Meanwhile, we'd need to fix for IdeaPad 3 in a different way. e.g. add a quirk entry to set alc_eapd_shutup or so. Adding Parsa to Cc for the further work.
thanks,
Takashi
sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index f787ff4182d4..86db1a4ec24c 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -587,6 +587,7 @@ static void alc_shutup_pins(struct hda_codec *codec) switch (codec->core.vendor_id) { case 0x10ec0236: case 0x10ec0256:
- case 0x10ec0257: case 0x19e58326: case 0x10ec0283: case 0x10ec0285:
-- 2.34.1