On Wed, Jun 19, 2019 at 05:46:34PM +0200, Pierre-Louis Bossart wrote:
On 6/19/19 5:02 PM, Andy Shevchenko wrote:
Switch the driver to use modern UUID API, i.e. guid_t type and accompanying functions, such as guid_equal().
Cc: Liam Girdwood lgirdwood@gmail.com Cc: Mark Brown broonie@kernel.org Cc: Vinod Koul vkoul@kernel.org Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
Looks good to me - couple of nit-picks below on unrelated indentation changes.
Reviewed-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
Thanks for review!
char mod_name[64]; /* guid str = 32 chars + 4 hyphens */
- uuid_le *uuid_mod;
- uuid_mod = (uuid_le *)guid; snprintf(mod_name, sizeof(mod_name), "%s%pUL%s",
"intel/dsp_fw_", uuid_mod, ".bin");
"intel/dsp_fw_", guid, ".bin");indentation looks off, not sure if this is a diff effect.
Ah, this can be modified to the below (by a separate patch, since Mark applied this one already):
snprintf(mod_name, sizeof(mod_name), "intel/dsp_fw_%pUL.bin", guid);
What do you think?
P.S. And it will take only one line.