On Thu, 2022-09-22 at 16:10 +0200, AngeloGioacchino Del Regno wrote:
Il 22/09/22 15:30, Mark Brown ha scritto:
On Thu, Sep 22, 2022 at 07:26:21PM +0800, Tzung-Bi Shih wrote:
snd_soc_pm_ops[1] sets some more fields. I'm not quite sure whether it would introduce any side effect or not. Perhaps Trevor could provide some suggestions.
If it does it should be to fix isues rather than introduce new problems - I suspect the other operations just don't work currently.
From my upstream tests, this didn't introduce any issues, that's why I've sent this patch.
In any case, let's check with Trevor, just as to be extremely sure, but please use an upstream kernel for eventual tests, as there are quite a bit of changes between 5.10 and current upstream.
Cheers, Angelo
I think it's not a big risk if Angelo already did the test and snd_soc_pm_ops is also used in MT8186. I can help do more tests on 5.10 when the patch is back to chromium in the future. MTK also have a plan to support complete suspend/resume functionality in MT8195. If Tzung-bi has concerns about the patch, I can help submit the patch at the time.
Thanks, Trevor