Hey David,
On Thu, May 18, 2023 at 09:14:49AM +0000, David Rau wrote:
- Convert Dialog DA7219 bindings to DT schema format.
- Add Jack insertion detection polarity selection.
- Remove unused `dlg,ldo-lvl` parameter.
Could you please split this out, so that the conversion is done in a patch of its own, with the addition separate (unless it is my unfamiliarity with sound at play, and the addition is required as part of the conversion).
diff --git a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml new file mode 100644 index 000000000000..32dfc4559052 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml @@ -0,0 +1,240 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/dialog,da7219.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Dialog Semiconductor DA7219 Audio Codec
+maintainers:
- David Rau David.Rau.opensource@dm.renesas.com
+description:
- The DA7219 is an ultra low-power audio codec with
- in-built advanced accessory detection (AAD) for mobile
- computing and accessory applications, which supports
- sample rates up to 96 kHz at 24-bit resolution.
+properties:
- compatible:
- enum:
- dlg,da7219
This is just a const.
- reg:
- description:
The I2C slave address of the DA7219.- maxItems: 1
Drop the description please, it's stating the obvious IMO.
- interrupts:
- description:
Interrupt for DA7219 IRQ line.- maxItems: 1
Ditto here.
- VDD-supply:
- description:
VDD power supply for the device.
I would say and here, but there seem to be dozens of other similar properties in sound.
- VDDMIC-supply:
- description:
VDDMIC power supply for the device.- VDDIO-supply:
- description:
VDDIO power supply for the device.- interrupt-names:
- description:
Name associated with interrupt line.Should be "wakeup" if interrupt is to be used to wake system,otherwise "irq" should be used.
Please encode these names using the items: field. + oneOf.
- wakeup-source:
type: boolean
- description:
Flag to indicate this device can wake system (suspend/resume).- "#clock-cells":
- description:
Two clock sources provided.
Drop the description here please.
- const: 1
- clock-output-names:
- description:
Names given for DAI clock outputs (WCLK & BCLK).
Please encode these as items:
- clocks:
- description:
phandle and clock specifier for codec MCLK.
maxItems: 1 & given the clock name I think you can drop both descriptions from here and clock-names.
- "da7219_aad":
Drop the quotes please.
dlg,jack-ins-det-pty:enum: ["low", "high"]description:Polarity for jack insertion detection.$ref: /schemas/types.yaml#/definitions/string$ref: /schemas/types.yaml#/definitions/uint32
Yeah, please do the change from txt -> yaml as one patch and this as another.
Cheers, Conor.