On Tue, 11 Aug 2020 23:33:13 +0200, Kees Cook wrote:
On Mon, Aug 03, 2020 at 02:16:15PM +0530, Allen wrote:
Here's the series re-based on top of 5.8 https://github.com/allenpais/tasklets/tree/V3
Great!
Let me know how you would want these to be reviewed.
Was a Coccinelle script used for any of these conversions? I wonder if it'd be easier to do a single treewide patch for the more mechanical changes.
And, actually, I still think the "prepare" patches should just be collapsed into the actual "covert" patches -- there are only a few.
After those, yeah, I think getting these sent to their respective maintainers is the next step.
Also, I was thinking if removing tasklets completely could be a task on KSPP wiki. If yes, I did like to take ownership of that task. I have a couple of ideas in mind, which could be discussed in a separate email.
Sure! I will add it to the tracker. Here's for the refactoring: https://github.com/KSPP/linux/issues/30
and here's for the removal: https://github.com/KSPP/linux/issues/94
if you can added details/examples of how they should be removed, that'd help other folks too, if they wanted to jump in. :)
I have a patch set to convert the remaining tasklet usage in sound drivers to either the threaded IRQ or the work, but it wasn't submitted / merged for 5.8 due to the obvious conflict with your API changes. Each conversion is rather simple, but it's always a question of the nature of each tasklet usage which alternative is the best fit.
FWIW, the current version is found in test/kill-tasklet branch of sound git tree git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
thanks,
Takashi