On Fri, Jul 14, 2017 at 03:36:57PM +0200, Linus Walleij wrote:
On Wed, Jul 12, 2017 at 5:55 PM, Johan Hovold johan@kernel.org wrote:
This reverts commit f1013cdeeeb9 ("ASoC: ux500: drop platform DAI assignments"), which seems to have been based on a misunderstanding and prevents the platform driver callbacks from being made (e.g. to preallocate DMA memory).
The real culprit for the warnings about attempts to create duplicate procfs entries was commit 99b04f4c4051 ("ASoC: add Component level pcm_new/pcm_free" that broke PCM creation on systems that use more than one platform component.
Fixes: f1013cdeeeb9 ("ASoC: ux500: drop platform DAI assignments") Cc: stable stable@vger.kernel.org # 4.11 Cc: Linus Walleij linus.walleij@linaro.org Signed-off-by: Johan Hovold johan@kernel.org
Reviewed-by: Linus Walleij linus.walleij@linaro.org Tested-by: Linus Walleij linus.walleij@linaro.org
These static assignments should go away, but not for the wrong reason. So this patch is fully in order given the source of the bug.
I assume you'll still need the of-related bits though (platform_of_node) even if you eventually make this driver use DT-instantiation only.
Thanks again, Johan