On Wed, May 24, 2023 at 12:28:10PM +0100, Mark Brown wrote:
On Tue, 23 May 2023 16:46:04 +0100, Srinivas Kandagatla wrote:
regmap-sdw does not support multi register writes, so there is no point in setting this flag. This also leads to incorrect programming of WSA codecs with regmap_multi_reg_write() call.
This invalid configuration should have been rejected by regmap-sdw.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: codecs: wsa883x: do not set can_multi_write flag commit: 40ba0411074485e2cf1bf8ee0f3db27bdff88394 [2/2] ASoC: codecs: wsa881x: do not set can_multi_write flag commit: 6e7a6d4797ef521c0762914610ed682e102b9d36
These were merged for 6.5 but the corresponding sanity check for regmap has now been included in 6.4-rc5 which consequently breaks these codecs (similar for wcd938x-sdw):
[ 11.443485] wsa883x-codec sdw:0:0217:0202:00:1: error -ENOTSUPP: regmap_init failed [ 11.443525] wsa883x-codec sdw:0:0217:0202:00:1: Probe of wsa883x-codec failed: -524 [ 11.443554] wsa883x-codec: probe of sdw:0:0217:0202:00:1 failed with error -52
Is it possible to get also these fixes into 6.4 final?
Johan