Re: [alsa-devel] [PATCH] ALSA: via82xx: Use common error handling code in snd_via82xx_create()

...

@@ -1153,6 +1150,14 @@ static int snd_via82xx_create(struct snd_card *card,

*r_via = chip; return 0; + +disable_device: + pci_disable_device(pci); + goto exit; +free_chip: + snd_via82xx_free(chip); +exit: + return err;

Doubly goto doesn't look like an improvement.

Would you like to integrate another software update with the statement “return err;” instead of “goto exit;” at this place? Regards, Markus