On Tue, 16 Jul 2019 16:33:15 +0200, Kai Vehmanen wrote:
Hi Takashi,
On Tue, 16 Jul 2019, Takashi Iwai wrote:
The recent fix for Icelake HDMI codec introduced the mapping from pin NID to the i915 gfx port number. However, it forgot the reverse mapping from the port number to the pin NID that is used in the ELD notifier callback. As a result, it's processed to a wrong widget and gives a warning like snd_hda_codec_hdmi hdaudioC0D2: HDMI: pin nid 5 not registered
This patch corrects it with a proper reverse mapping function.
looks good:
Reviewed-by: Kai Vehmanen kai.vehmanen@linux.intel.com
Thanks for the review.
Actually I found one minor problem now. The caller doesn't handle the error case returned from intel_port2pin(). It should be harmless, but it's better to bail out earlier.
Will resubmit the v2 patch (only for patch 2/2) with the correction.
Takashi