On 28/01/2020 17:42, Dmitry Osipenko wrote:
28.01.2020 15:13, Mark Brown пишет:
On Mon, Jan 27, 2020 at 10:20:25PM +0300, Dmitry Osipenko wrote:
24.01.2020 19:50, Jon Hunter пишет:
.rates = SNDRV_PCM_RATE_8000_96000, .formats = SNDRV_PCM_FMTBIT_S32_LE |
SNDRV_PCM_FMTBIT_S24_LE |
SNDRV_PCM_FMTBIT_S24_3LE |It should solve the problem in my particular case, but I'm not sure that the solution is correct.
If the format implemented by the driver is S24_3LE the driver should advertise S24_3LE.
It should be S24_LE, but seems we still don't know for sure.
Why?
The v5.5 kernel is released now with the broken audio and apparently getting 24bit to work won't be trivial (if possible at all). Ben, could you please send a patch to fix v5.5 by removing the S24 support advertisement from the driver?
Why is that the best fix rather than just advertising the format implemented by the driver?
The currently supported format that is known to work well is S16_LE.
I'm suggesting to drop the S24_LE and S32_LE that were added by the applied patches simply because this series wasn't tested properly before it was sent out and turned out that it doesn't work well.
S32_LE should be fine, however, I do have some concerns about S24_LE.
Jon