On Tue, May 08, 2012 at 03:15:14PM +0300, Peter Ujfalusi wrote:
abe-twl6040,jack_detection = <0>;
Shouldn't this be a boolean property that simply needs to be present to flag detection?
dai-link1,codec = <&twl6040_codec>; dai-link1,dai = <&mcpdm>;
This seems like it ought to be an array of nodes, one per link, instead of having an index in the property name. It should certainly be easier to parse.
It also seems like it's not at all board specific and should be factored out.
abe-twl6040,audio-routing = "Headset Stereophone", "HSOL", "Headset Stereophone", "HSOR",
Binding should document what the board-defined nodes are.
+Example:
+sound { /* ASoC */
- compatible = "ti,abe-twl6040";
- abe-twl6040,model = "SDP4430";
Please don't repeat your binding documentation in the changelog, it's already in the patch and means it comes after the documentation.