Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls

On Wed 25-01-23 00:38:48, Suren Baghdasaryan wrote:

Replace direct modifications to vma->vm_flags with calls to modifier functions to be able to track flag changes and to keep vma locking correctness.

Is this a manual (git grep) based work or have you used Coccinele for the patch generation?

My potentially incomplete check $ git grep ">[[:space:]]*vm_flags[[:space:]]*[&|^]="

shows that nothing should be left after this. There is still quite a lot of direct checks of the flags (more than 600). Maybe it would be good to make flags accessible only via accessors which would also prevent any future direct setting of those flags in uncontrolled way as well.

Anyway Acked-by: Michal Hocko mhocko@suse.com