30 Jan
2020
30 Jan
'20
4:14 p.m.
Thanks for the review Mark,
+static int sof_pcm512x_codec_init(struct snd_soc_pcm_runtime *rtd) +{
- struct snd_soc_component *codec = rtd->codec_dai->component;
- snd_soc_component_update_bits(codec, PCM512x_GPIO_EN, 0x08, 0x08);
- snd_soc_component_update_bits(codec, PCM512x_GPIO_OUTPUT_4, 0x0f, 0x02);
- snd_soc_component_update_bits(codec, PCM512x_GPIO_CONTROL_1,
0x08, 0x08);These look like they might be a DAPM widget of some kind?
it's the LED support only, turned on when you play and off when you stop. At some point, I added a gpiochip support in the PCM152x codec driver to avoid doing this, and have a nicer way of toggling the gpios. Due to lack of time, I didn't maintain this solution, but we could add it in a follow-up version if that was desired. It's really not the main functionality of this patch. -Pierre