Re: [alsa-devel] [PATCH 2/3] ASoC: simple-card: use devm_get_clk_from_child()

On 12/05, Kuninori Morimoto wrote:

diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c index cf02625..4924575 100644 --- a/sound/soc/generic/simple-card-utils.c +++ b/sound/soc/generic/simple-card-utils.c @@ -98,7 +98,8 @@ int asoc_simple_card_parse_card_name(struct snd_soc_card *card, } EXPORT_SYMBOL_GPL(asoc_simple_card_parse_card_name);

-int asoc_simple_card_parse_clk(struct device_node *node, +int asoc_simple_card_parse_clk(struct device *dev,

• 	       struct device_node *node,
         struct device_node *dai_of_node,
         struct asoc_simple_dai *simple_dai)
  

{ @@ -111,14 +112,13 @@ int asoc_simple_card_parse_clk(struct device_node *node, * or "system-clock-frequency = <xxx>" * or device's module clock. */

• clk = of_clk_get(node, 0);

• clk = devm_get_clk_from_child(dev, node, NULL); if (!IS_ERR(clk)) { simple_dai->sysclk = clk_get_rate(clk);

• simple_dai->clk = clk;
  

  } else if (!of_property_read_u32(node, "system-clock-frequency", &val)) { simple_dai->sysclk = val; } else {

• clk = of_clk_get(dai_of_node, 0);
  

• clk = devm_get_clk_from_child(dev, dai_of_node, NULL);
  

I was confused for a minute about how the second of_clk_get() call with the dai_link node could work. Is that documented anywhere or used by anyone? It seems like it's at least another child node of the sound node (which is dev here) so it seems ok.

if (!IS_ERR(clk))
	simple_dai->sysclk = clk_get_rate(clk);

}