On Thu, Oct 31, 2013 at 09:46:40AM -0200, Mauro Carvalho Chehab wrote:
Hi Russell,
Em Mon, 30 Sep 2013 13:57:47 +0200 Hans Verkuil hverkuil@xs4all.nl escreveu:
On 09/19/2013 11:44 PM, Russell King wrote:
Replace the following sequence:
dma_set_mask(dev, mask); dma_set_coherent_mask(dev, mask);
with a call to the new helper dma_set_mask_and_coherent().
Signed-off-by: Russell King rmk+kernel@arm.linux.org.uk
Acked-by: Hans Verkuil hans.verkuil@cisco.com
Somehow, I lost your original post (I got unsubscribed on a few days from all vger mailing lists at the end of september).
I suspect that you want to sent this via your tree, right?
Yes please.
If so:
Acked-by: Mauro Carvalho Chehab m.chehab@samsung.com
Added, thanks.
- err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
- if (err)
return -ENODEV;- err = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
- err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); if (err) return -ENODEV;
One thing I've just noticed is that return should be "return err" not "return -ENODEV" - are you okay for me to change that in this patch?
Thanks.