Re: [alsa-devel] [PATCH] ASoC: adau1701: fix adau1701_reg_read()

On 07/03/2014 04:51 PM, Daniel Mack wrote:

Fix a long standing bug in the read register routing of adau1701. The bytes arrive in the buffer in big-endian, so the result has to be shifted before and-ing the bytes in the loop.

Signed-off-by: Daniel Mack zonque@gmail.com

Acked-by: Lars-Peter Clausen lars@metafoo.de

Thanks.

---

sound/soc/codecs/adau1701.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c index defb277..15feb12 100644 --- a/sound/soc/codecs/adau1701.c +++ b/sound/soc/codecs/adau1701.c @@ -240,8 +240,10 @@ static int adau1701_reg_read(void *context, unsigned int reg,

*value = 0;

• for (i = 0; i < size; i++)

• *value |= recv_buf[i] << (i * 8);
  

• for (i = 0; i < size; i++) {

• *value <<= 8;
  

• *value |= recv_buf[i];
  

• }

  return 0; }