-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Thursday, August 07, 2014 4:54 AM To: Bard Liao Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; lars@metafoo.de; Flove; Oder Chiou Subject: Re: [PATCH] ASoC: rt286: Add API to set supported jack type
On Tue, Aug 05, 2014 at 01:52:50PM +0800, bardliao@realtek.com wrote:
From: Bard Liao bardliao@realtek.com
RT286 need to configure the jack type (combo or non-combo) according to the HW design. This function is given a easy way to set the correct jacy type for those without platform data supported.
If this is coming from the hardware design I'd expect this to be configured via platform data or firmware data rather than with an API. Why do it this way?
Actually, this patch is for Intel platform which doesn't support platform data yet. That's why we create an API so they can call the API in machine driver.
------Please consider the environment before printing this e-mail.