2 Mar
2019
2 Mar
'19
6:47 a.m.
Hi
On Fri, Mar 01, 2019 at 08:37:08AM +0000, S.j. Wang wrote:
There is constraint for the channel number setting on the
nit: "a constraint"
asrc of older version (e.g. imx35), the channel number should be even, odd number isn't valid.
+static int fsl_asrc_dai_startup(struct snd_pcm_substream *substream,
struct snd_soc_dai *dai)+{
- struct fsl_asrc *asrc_priv = snd_soc_dai_get_drvdata(dai);
- /* channel_bits = 3 means older version on imx35*/
Space between '5' and '*'. And better to make it clear:
/* Odd channel number is not valid for older ASRC (channel_bits==3) */
- if (asrc_priv->channel_bits == 3)
snd_pcm_hw_constraint_step(substream->runtime, 0,SNDRV_PCM_HW_PARAM_CHANNELS, 2);
For your next version,
Acked-by: Nicolin Chen nicoleotsuka@gmail.com
Ok, thanks, will send v3.
Cheers