-----Original Message----- From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com] Sent: Wednesday, August 03, 2011 5:32 PM To: Dong Aisheng-B29396 Cc: Takashi Iwai; alsa-devel@alsa-project.org; s.hauer@pengutronix.de; lrg@ti.com; linux-arm-kernel@lists.infradead.org; w.sang@pengutronix.de Subject: Re: [alsa-devel] [PATCH 1/1] ASoC: core: cache index fix
On Wed, Aug 03, 2011 at 07:39:27AM +0000, Dong Aisheng-B29396 wrote:
Can we fix FLAT first since it is most used and let rbtree and LZO as
before?
Leaving rbtree and LZO alone is exactly what I've been saying!
Sorry for not catch your point before.
Do you think the my patch that provides a register and cache index conversion helper function behind for FLAT could be a way to try?
If yes, I can clean my patch to only include FLAT fix and send it out for You to take a look.
Using this method, codec driver does not need to pad the default cache array. During the cache read, the register will be automatically converted to cache index to fetch value. This can also fix the soc_codec_reg_show for codecs who are using packed (FLAT) Cache while step = 2. (Here I assume the packed cache only has a different step with FLAT cache. FIXME if wrong)