-----Original Message----- From: Maarten Zanders maarten.zanders@mind.be Sent: Friday, October 28, 2022 5:26 PM To: Lars-Peter Clausen lars@metafoo.de; Sa, Nuno Nuno.Sa@analog.com; Liam Girdwood lgirdwood@gmail.com; Mark Brown broonie@kernel.org; Jaroslav Kysela perex@perex.cz; Takashi Iwai tiwai@suse.com Cc: Maarten Zanders maarten.zanders@mind.be; alsa-devel@alsa- project.org; linux-kernel@vger.kernel.org Subject: [PATCH 3/3] ASoC: adau1372: correct PGA enable & mute bit
[External]
The DAPM control for PGAx uses the PGA mute bit for power management. This bit is active high but is set to non-inverted (ie when powering, it will mute). The ALSA control "PGA x Capture Switch" uses the active high PGA_ENx bit, but is set to inverted. So when enabling this switch, the PGA gets disabled.
To correct the behaviour, invert both these bits.
Signed-off-by: Maarten Zanders maarten.zanders@mind.be
Also looks like a fix so a Fixes: tag? If so, the patch should come before ("ASoC: adau1372: add support for S24_LE mode")
- Nuno Sá