Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: Remove custom fsl_ssi_debugfs_create/remove()

On Wed, Apr 08, 2015 at 01:54:22PM -0300, Fabio Estevam wrote:

From: Fabio Estevam fabio.estevam@freescale.com

Since commit 81c7cfd1b22a0 ("ASoC: Move debugfs registration to the component level") ASoC core code deals with registering debugfs, so we should remove the custom fsl_ssi_debugfs_create/remove() to avoid the following warning:

So this sounds like an issue but...

-int fsl_ssi_debugfs_create(struct fsl_ssi_dbg *ssi_dbg, struct device *dev) -{

• ssi_dbg->dbg_dir = debugfs_create_dir(dev_name(dev), NULL);
• if (!ssi_dbg->dbg_dir)

• return -ENOMEM;
  

• ssi_dbg->dbg_stats = debugfs_create_file("stats", S_IRUGO,

• 	ssi_dbg->dbg_dir, ssi_dbg, &fsl_ssi_stats_ops);
  

• if (!ssi_dbg->dbg_stats) {

• debugfs_remove(ssi_dbg->dbg_dir);
  

• return -ENOMEM;
  

• }
• return 0;

-}

...shouldn't this just be removing the creation of the directory, not the stats file that was being put inside it?