Re: [PATCH v3 01/11] driver: platform: Add helper for safer setting of driver_override

1 Mar 2022

      On 28/02/2022 21:03, Bjorn Helgaas wrote:
...
On Sun, Feb 27, 2022 at 02:52:04PM +0100, Krzysztof Kozlowski wrote:
...
Several core drivers and buses expect that driver_override is a
dynamically allocated memory thus later they can kfree() it.
...
+int driver_set_override(struct device *dev, const char **override,

	const char *s, size_t len)

+{

const char *new, *old;
char *cp;

if (!dev || !override || !s)
return -EINVAL;

/* We need to keep extra room for a newline */

It would help a lot to extend this comment with a hint about where the
room for a newline is needed.  It was confusing even before, but it's
much more so now that the check is in a completely different file than
the "show" functions that need the space.
Indeed, this needs explanation.
Best regards,
Krzysztof