Hi Richard,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on broonie-sound/for-next] [also build test WARNING on lee-mfd/for-mfd-next linusw-pinctrl/devel linusw-pinctrl/for-next broonie-regulator/for-next linus/master v6.1-rc4 next-20221111] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Richard-Fitzgerald/Add-suppor... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/20221109165331.29332-4-rf%40opensource.cirrus.com patch subject: [PATCH 03/12] mfd: cs48l32: Add support for CS48L31/32/33 codecs config: arm-randconfig-c002-20221111 compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 463da45892e2d2a262277b91b96f5f8c05dc25d0) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/intel-lab-lkp/linux/commit/e5417b42692fa57b7987ecb90833e0... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Richard-Fitzgerald/Add-support-for-the-Cirrus-Logic-CS48L32-audio-codecs/20221110-005630 git checkout e5417b42692fa57b7987ecb90833e01e67186d0e # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/mfd/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
drivers/mfd/cs48l32.c:184:21: warning: attribute declaration must precede definition [-Wignored-attributes]
static const struct __maybe_unused of_device_id cs48l32_of_match[] = { ^ include/linux/compiler_attributes.h:326:56: note: expanded from macro '__maybe_unused' #define __maybe_unused __attribute__((__unused__)) ^ include/linux/mod_devicetable.h:268:8: note: previous definition is here struct of_device_id { ^ 1 warning generated.
vim +184 drivers/mfd/cs48l32.c
183
184 static const struct __maybe_unused of_device_id cs48l32_of_match[] = {
185 { .compatible = "cirrus,cs48l31", }, 186 { .compatible = "cirrus,cs48l32", }, 187 { .compatible = "cirrus,cs48l33", }, 188 {}, 189 }; 190