On Thu, Apr 13, 2023 at 07:42:06AM +0200, Takashi Iwai wrote:
On Wed, 12 Apr 2023 21:59:28 +0200, Jaroslav Kysela wrote:
This looks like a sane proposal, but some drivers does not require the silencing at all, so we can probably skip this step for them (new SNDRV_PCM_INFO_PERFECT_DRAIN flag?).
Sure, we should apply it only conditionally.
i don't think the extra complexity is justified. with my improved proposal, we're talking about a cost of filling two periods per draining op, which aren't exactly super-frequent.
Also, we may skip the workaround for applications accessing directly via mmap as default.
no, because one may easily miss that more than one period is required. also, i think that forgetting it entirely is an easy mistake to make, even if it's harder with mmap than with write.
regards