Re: [alsa-devel] [PATCH] ASoC: da732x: Print correct major id

On Thu, Apr 3, 2014 at 12:57:32PM +0000, Axel Lin wrote:

DA732X_ID_MAJOR_MASK is 0xF0, so the major id is (reg & DA732X_ID_MAJOR_MASK) >> 4.

Signed-off-by: Axel Lin axel.lin@ingics.com

sound/soc/codecs/da732x.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/da732x.c b/sound/soc/codecs/da732x.c index 7d168ec..48f3fef 100644 --- a/sound/soc/codecs/da732x.c +++ b/sound/soc/codecs/da732x.c @@ -1571,7 +1571,8 @@ static int da732x_i2c_probe(struct i2c_client *i2c, }

dev_info(&i2c->dev, "Revision: %d.%d\n",

•  (reg & DA732X_ID_MAJOR_MASK), (reg &
  

DA732X_ID_MINOR_MASK));

•  (reg & DA732X_ID_MAJOR_MASK) >> 4,
  

•  (reg & DA732X_ID_MINOR_MASK));
  
  

  ret = snd_soc_register_codec(&i2c->dev, &soc_codec_dev_da732x, da732x_dai, ARRAY_SIZE(da732x_dai));

-- 1.8.3.2

Acked-by: Adam Thomson Adam.Thomson.Opensource@diasemi.com