On Thu, 23 Jul 2015 17:26:15 +0200, David Henningsson wrote:
Changes since v2 is that the patch set has diminished to not transfer connector/eld information, since it might be better that such information to be transferred by a separate call in the ordinary direction. That could be added in a later patch set.
The audio_ptr is now a void* (instead of a hdac_bus*) so that the audio side can easily refactor the ptr to point to the codec instead of the bus if we would find that beneficial.
OK, that leaves some room if we want to change in future.
I still consider whether it's better to register from the codec driver or from the bus driver. The codec driver might be a bit cleaner, but then it'd be a call like snd_hda_i915_register_notifier() instead of adding a callback in the codec ops.
What I see a bit ugly in the current patchset is the addition of i915 specific callback to a generic hda codec ops. If the codec registers the callback dynamically like above, the pointer will be stored in component directly, so we don't need it in codec ops. (But we'd need to unregister at codec removal, too.)
Or, if we keep it as a codec ops callback, as already mentioned, it might make more sense to define it as a generic notifier, i.e. drop i915 prefix and pass some event type to identify the event.
thanks,
Takashi
David Henningsson (4): drm/i915: Add audio hotplug info callback drm/i915: Call audio hotplug notify function ALSA: hda - Dispatch incoming HDMI hotplug i915 callback ALSA: hda - Wake the codec up on hotplug notify events
drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_audio.c | 23 ++++++++++++++++++++--- include/drm/i915_component.h | 5 +++++ include/sound/hdaudio.h | 4 ++++ sound/hda/hdac_i915.c | 23 +++++++++++++++++++++++ sound/pci/hda/patch_hdmi.c | 13 ++++++++++++- 6 files changed, 65 insertions(+), 4 deletions(-)
-- 1.7.9.5