Hi Nick,
'ret' is only defined in if branches and for loops (e.g. for_each_component_dais). If none of these branches or loops get executed, then eventually we end up having
int ret;
err_probe: if (ret < 0) soc_cleanup_component(component);
With -ftrivial-auto-var-init=pattern, this code becomes
int ret;
err_probe: ret = 0xAAAAAAAA; if (ret < 0) soc_cleanup_component(component);
So soc_cleanup_component gets called unintentionally this case, which causes the built kernel to miss some files.
On Thu, Feb 6, 2020 at 3:28 PM Nick Desaulniers ndesaulniers@google.com wrote:
Fixed the uninitialized use of a signed integer variable ret in soc_probe_component when all its definitions are not executed. This caused -ftrivial-auto-var-init=pattern to initialize the variable to repeated 0xAA (i.e. a negative value) and triggered the following code unintentionally.
Signed-off-by: Jian Cai caij2003@gmail.com
Hi Jian, I don't quite follow; it looks like `ret` is assigned to multiple times in `soc_probe_component`. Are one of the return values of one of the functions that are called then assigned to `ret` undefined? What control flow path leaves `ret` unitialized?