Hi Pierre-Louis,
I love your patch! Yet something to improve:
[auto build test ERROR on sound/for-next] [also build test ERROR on v4.18-rc6 next-20180725] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Pierre-Louis-Bossart/ALSA-memalloc-... base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next config: microblaze-allmodconfig (attached as .config) compiler: microblaze-linux-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.1.0 make.cross ARCH=microblaze
All errors (new ones prefixed by >>):
In file included from include/sound/pcm.h:27, from sound/core/pcm_iec958.c:11: include/sound/memalloc.h: In function 'snd_sgbuf_aligned_pages': include/sound/memalloc.h:75:17: error: 'PAGE_SIZE' undeclared (first use in this function); did you mean 'TASK_SIZE'? return (size + PAGE_SIZE - 1) >> PAGE_SHIFT; ^~~~~~~~~ TASK_SIZE include/sound/memalloc.h:75:17: note: each undeclared identifier is reported only once for each function it appears in
include/sound/memalloc.h:75:35: error: 'PAGE_SHIFT' undeclared (first use in this function); did you mean 'NMI_SHIFT'?
return (size + PAGE_SIZE - 1) >> PAGE_SHIFT; ^~~~~~~~~~ NMI_SHIFT
vim +75 include/sound/memalloc.h
69 70 /* 71 * return the pages matching with the given byte size 72 */ 73 static inline unsigned int snd_sgbuf_aligned_pages(size_t size) 74 {
75 return (size + PAGE_SIZE - 1) >> PAGE_SHIFT;
76 } 77
--- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation