On 2022-07-05 5:58 PM, Andy Shevchenko wrote:
device_get_match_data() in ACPI case calls similar to acpi_match_device(). Hence there is no need to duplicate the call. Just assign what is in the id->driver_data.
Thanks for the patch! Change looks good:
Acked-by: Cezary Rojewski cezary.rojewski@intel.com
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
v3: moved spec assignment closer to its user (Péter, Czarek) sound/soc/intel/catpt/device.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/sound/soc/intel/catpt/device.c b/sound/soc/intel/catpt/device.c index 85a34e37316d..d48a71d2cf1e 100644 --- a/sound/soc/intel/catpt/device.c +++ b/sound/soc/intel/catpt/device.c @@ -254,14 +254,11 @@ static int catpt_acpi_probe(struct platform_device *pdev) return -ENODEV; }
- spec = device_get_match_data(dev);
- if (!spec)
return -ENODEV;- cdev = devm_kzalloc(dev, sizeof(*cdev), GFP_KERNEL); if (!cdev) return -ENOMEM;
spec = (const struct catpt_spec *)id->driver_data; catpt_dev_init(cdev, dev, spec);
/* map DSP bar address */