Hi,
On 07/20/2018 04:53 AM, Bard Liao wrote:
-----Original Message----- From: Pierre-Louis Bossart [mailto:pierre-louis.bossart@linux.intel.com] Sent: Friday, July 20, 2018 9:40 AM To: Bard Liao; Mark Brown; Hans de Goede Cc: Liam Girdwood; Oder Chiou; alsa-devel@alsa-project.org; Carlo Caione Subject: Re: [alsa-devel] [PATCH 1/6] ASoC: rt5651: Add IN3 Boost volume control
On 07/19/2018 08:31 PM, Bard Liao wrote:
-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Thursday, July 19, 2018 11:03 PM To: Hans de Goede Cc: Liam Girdwood; Bard Liao; Oder Chiou; Pierre-Louis Bossart; Carlo
Caione;
alsa-devel@alsa-project.org Subject: Re: [PATCH 1/6] ASoC: rt5651: Add IN3 Boost volume control
On Wed, Jul 18, 2018 at 10:55:37PM +0200, Hans de Goede wrote:
- /* IN1/IN2/IN3 Control */ SOC_SINGLE_TLV("IN1 Boost", RT5651_IN1_IN2, RT5651_BST_SFT1, 8, 0, bst_tlv), SOC_SINGLE_TLV("IN2 Boost", RT5651_IN1_IN2, RT5651_BST_SFT2, 8, 0, bst_tlv),
- SOC_SINGLE_TLV("IN3 Boost", RT5651_IN3,
RT5651_BST_SFT1, 8, 0, bst_tlv),These should all have Volume added to the name however that's a preexisting bug so not a blocker on this.
I will add "Volume" to the name for all of them.
isn't this going to break userspace configs if we change the name of controls?
Yes, it should be modified, too.
Or we just live with the "Volume" part missing for these 3 and don't break users existing setup for no good reason.
Regards,
Hans