2011/12/6 Austin, Brian Brian.Austin@cirrus.com:
On Dec 5, 2011, at 8:01 PM, "Tomoya MORINAGA" tomoya.rohm@gmail.com wrote:
2011/12/6 Mark Brown broonie@opensource.wolfsonmicro.com:
According to "machine.txt", I created this machine driver referring corgi.c/spitz.c. However, corgi.c/spitz.c. don't look obeying your saying.
You really need to look at current drivers to make sure you're following current best practice - older drivers, particularly for obsolte hardware like the Zaurus machines, may well not reflect the current best practices.
I see. I won't read this docs.
BTW, Let me know the best practice of machine driver? I can't identify which driver is modern or not.
Check the OMAP and Samsung directories. Those are pretty current
Thanks. However, i2c access code is not included in Samsung. Though OMAP includes i2c access code like below, omap/sdp3430.c: twl_i2c_read_u8(TWL4030_MODULE_INTBR, &pin_mux, omap/sdp3430.c: twl_i2c_write_u8(TWL4030_MODULE_INTBR, pin_mux, this code doesn't seem applicable for me.
Could you show best practice for i2c access of machine driver?
thanks, tomoya