Hi Charles,
I love your patch! Yet something to improve:
[auto build test ERROR on broonie-sound/for-next] [also build test ERROR on tegra/for-next sunxi/sunxi/for-next linus/master v5.19-rc3 next-20220622] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Charles-Keepax/Refactor-non_l... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next config: mips-db1xxx_defconfig (https://download.01.org/0day-ci/archive/20220623/202206230910.wUXKFP3z-lkp@i...) compiler: mipsel-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/794205d61285d0921e564e722daf9b... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Charles-Keepax/Refactor-non_legacy_dai_naming-flag/20220616-224300 git checkout 794205d61285d0921e564e722daf9b20df82ed57 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash sound/soc/au1x/
If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot lkp@intel.com
All error/warnings (new ones prefixed by >>):
sound/soc/au1x/ac97c.c:227:10: error: 'const struct snd_soc_component_driver' has no member named 'legacy_dai_name'; did you mean 'legacy_dai_naming'?
227 | .legacy_dai_name = 1, | ^~~~~~~~~~~~~~~ | legacy_dai_naming
sound/soc/au1x/ac97c.c:227:35: warning: initialization of 'const struct snd_kcontrol_new *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
227 | .legacy_dai_name = 1, | ^ sound/soc/au1x/ac97c.c:227:35: note: (near initialization for 'au1xac97c_component.controls')
vim +227 sound/soc/au1x/ac97c.c
224 225 static const struct snd_soc_component_driver au1xac97c_component = { 226 .name = "au1xac97c",
227 .legacy_dai_name = 1,
228 }; 229