On 25-11-20, 09:51, Takashi Iwai wrote:
On Thu, 19 Nov 2020 03:51:19 +0100, Gyeongtaek Lee wrote:
On Fri, 06 Nov 2020 09:58:24 +0100, Takashi Iwai wrote:
On Tue, 27 Oct 2020 02:57:25 +0100, Gyeongtaek Lee wrote:
With a stream with low bitrate, user can't pause or resume the stream near the end of the stream because current ALSA doesn't allow it. If the stream has very low bitrate enough to store whole stream into the buffer, user can't do anything except stop the stream and then restart it from the first because most of applications call draining after sending last frame to the kernel. If pause, resume are allowed during draining, user experience can be enhanced. To prevent malfunction in HW drivers which don't support pause during draining, pause during draining will only work if HW driver enable this feature explicitly by calling snd_compr_use_pause_in_draining().
Signed-off-by: Gyeongtaek Lee gt82.lee@samsung.com Cc: stable@vger.kernel.org
I personally find the approach is fine, but let's see what others think.
One remaining concern to me is about the setup of use_pause_in_draining flag. This is done by an explicit function call after the snd_compr object initialization. It's a bit uncommon style, but OTOH I understand it from the current initialization code of compress-offload API.
Thanks for your kind review.
It's been almost 2 weeks. So, I think that there is no further comment for this patch.
I guess it's just overlooked. Vinod?
Sorry indeed this seems to have slipped, this mostly looks okay to me (saw some code style nits will reply on those)
I have todo in my list to fix use of PCM_STATE in compress, i will send that later