On Wed, May 17, 2017 at 5:50 PM, Takashi Iwai tiwai@suse.de wrote:
On Wed, 17 May 2017 13:38:56 +0200, Bhumika Goyal wrote:
Declare snd_kcontrol_new structures as const as they are only passed an argument to the function snd_ctl_new1. This argument is of type const, so snd_kcontrol_new structures having this property can be made const. Done using Coccinelle:
@r disable optional_qualifier@ identifier x; position p; @@ static struct snd_kcontrol_new x@p={...};
@ok@ identifier r.x; position p; @@ snd_ctl_new1(&x@p,...)
@bad@ position p != {r.p,ok.p}; identifier r.x; @@ x@p
@depends on !bad disable optional_qualifier@ identifier r.x; @@ +const struct snd_kcontrol_new x;
Signed-off-by: Bhumika Goyal bhumirks@gmail.com
As I already asked, could you send as a patchset if you have multiple similar patches?
Sure. Will combine the already sent ones and some new ones into a patchset and send again.
Thanks, Bhumika
thanks,
Takashi