On 18/06/2021 21:16, Rob Herring wrote:
On Mon, Jun 07, 2021 at 04:28:26PM +0100, Srinivas Kandagatla wrote:
This patch adds bindings support for Qualcomm Audio Processing Manager service in Audio DSP.
Audio Process Manager is one of the static service in DSP which is responsible for Command/response handling, graph Management and Control/Event management between modules.
Signed-off-by: Srinivas Kandagatla srinivas.kandagatla@linaro.org
.../devicetree/bindings/sound/qcom,q6apm.yaml | 72 +++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6apm.yaml
diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml new file mode 100644 index 000000000000..9906ef935206 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml @@ -0,0 +1,72 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/sound/qcom,q6apm.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+title: Qualcomm Audio Process Manager binding
+maintainers:
- Srinivas Kandagatla srinivas.kandagatla@linaro.org
+description: |
- This binding describes the Qualcomm Audio Process Manager service in DSP
+properties:
- compatible:
- const: qcom,q6apm
- reg:
- maxItems: 1
+#APM Services +patternProperties:
- "^.*@[0-9a-f]+$":
You can drop '^.*'.
Thanks Rob for review,
will fix this along other comments in next spin.
--srini
- type: object
- description:
APM devices use subnodes for services.- properties:
compatible:enum:- qcom,q6apm-dai- qcom,q6apm-bedaiiommus:maxItems: 1"#sound-dai-cels":cells?
How is this optional?
const: 1- required:
- compatible- reg- additionalProperties: false
+required:
- compatible
- reg
+additionalProperties: true
This needs to be false and fix whatever is missing.
+examples:
- |
- gpr {
#address-cells = <1>;#size-cells = <0>;gprservice@1 {compatible = "qcom,q6apm";reg = <1>;q6apm-dai {This doesn't match what you have in the schema at all.
compatible = "qcom,q6apm-dai";#sound-dai-cels = <1>;};q6apm-bedai {compatible = "qcom,q6apm-bedai";#sound-dai-cels = <1>;};};- };
-- 2.21.0