Re: [alsa-devel] [PATCH RFC 24/26] [media] solo6x10: Convert to copy_silence ops

11 May 2017


      On Thu, 11 May 2017 23:09:23 +0200,
Takashi Iwai wrote:
...
@@ -242,10 +242,11 @@ static int snd_solo_pcm_copy(struct snd_pcm_substream *ss, int channel,
   	if (err)
   		return err;

err = copy_to_user(dst + (i * G723_PERIOD_BYTES),




if (in_kernel)


	memcpy((void *)dst + (i * G723_PERIOD_BYTES),


	       solo_pcm->g723_buf, G723_PERIOD_BYTES);


else if (copy_to_user(dst + (i * G723_PERIOD_BYTES),
	   solo_pcm->g723_buf, G723_PERIOD_BYTES);



Here is an obvious error, as kbuild bot spotted.
I fixed in topic/kill-set_fs branch now.
Takashi

    