Re: [alsa-devel] [PATCH 11/15] sound: soc: poodle: make use of new locomo GPIO interface

On Tue, Oct 28, 2014 at 03:02:04AM +0300, Dmitry Eremin-Solenikov wrote:

Since LoCoMo driver has been converted to provide proper gpiolib interface, make poodle ASoC platform driver use gpiolib API.

Please use subject lines matching the style for the subsystem.

• ret = gpio_request_array(poodle_gpios, ARRAY_SIZE(poodle_gpios));
• if (ret) {

• dev_err(&pdev->dev, "gpio_request_array() failed: %d\n",
  

• 		ret);
  

• return ret;
  

• }

I sense a need for devm_gpio_request_array() here. Otherwise this looks fine - ideally it'd move to gpiod but moving to gpiolib is a clear win so no need to block on this.

Acked-by: Mark Brown broonie@kernel.org

with at least the subject line fixed.