On Wed, 11 Oct 2017 15:03:29 +0200, Greg KH wrote:
On Wed, Oct 11, 2017 at 12:36:37PM +0200, Takashi Iwai wrote:
Hi,
this is a revised patch set to cover the codes that may submit URBs containing invalid EPs without validation, which result in the kernel warning from the USB core. The first patch adds a new helper for simplifying the EP check, and the rest applies it at needed places.
The original issues were spotted by syzkaller, and I put a few others for covering more similar cases.
The only updated code in v2 is about the first patch to add usb_urb_ep_type_check() helper (in addition to tested-by tag from Andrey). Typos were fixed and it's called also from usb_submit_urb() as Greg suggested, too.
USB devs: does this look OK now?
If yes, and if I get acks, I can take the patches to sound tree. Or I don't mind if you take all to usb tree, too. Or maybe better, I'll prepare an immutable branch based on 4.4.14-rc (rc4 for now) in case you want to pull into both trees. Let me know your wish.
Whole series looks good to me, feel free to take them in your tree if that's the easiest:
Acked-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
No need for a branch, merges in this area should be rare...
Great, thanks for a quick review! I'll merge through sound git tree.
Takashi