19 Oct
2009
19 Oct
'09
2:59 p.m.
On Monday 19 October 2009 15:55:08 ext Mark Brown wrote:
On Mon, Oct 19, 2009 at 03:42:19PM +0300, Peter Ujfalusi wrote:
- apll_ctrl = twl4030_read_reg_cache(codec, TWL4030_REG_APLL_CTL);
- apll_ctrl &= ~TWL4030_APLL_INFREQ; switch (freq) {
I'll apply this - it's idiomatic for the current driver - but you might want to look at snd_soc_update_bits() which does a read/modify/write cycle for you.
Yeah, it is a good idea. I'll address this when I go through the soc codec driver in my planned revisit and cleanup round quite soon.
Thanks, Péter