Re: [alsa-devel] Regression caused by "ASoC: core: Rework SOC_DOUBLE_R_SX_TLV add SOC_SINGLE_SX_TLV"

Dear Brian Austin,

On Thu, 30 Jan 2014 11:13:36 -0600, Brian Austin wrote:

...

I've tried again, and I confirm the problem. When the PCM is muted, I can only toggle it between the values 62 and 64. When the PCM is unmuted, I can only toggle it between the values 60 and 61.

OK, that is very odd. I will take a look when I get a chance. I have an L51 board, but need to do some other stuff first.

Ok, thanks!

...

The ugly attached patch fixes the problem for me (the patch is a partial revert of your patch).

Thanks! but...

     SOC_DOUBLE_R_SX_TLV("Analog Playback Volume",
                     CS42L51_AOUTA_VOL, CS42L51_AOUTB_VOL,

•                   0, 0x34, 0xE4, aout_tlv),
  

•                   8, 0xffffff19, 0x18, aout_tlv),
     SOC_DOUBLE_R_SX_TLV("ADC Mixer Volume",
  
  

shifting 8 on an 8bit register?

These values are just the ones that were here before your commit 1d99f2436d0d1c7741d6dfd9d27b5376cdbbca40. I didn't invent anything, just reverted partially your commit.

Thomas