At Thu, 13 Nov 2008 01:14:51 +0100, Diego 'Flameeyes' Pettenò wrote:
Hi all,
Since I have just had to fix (again) an --as-needed issues on alsa-tools on the Gentoo ebuild, I've decided to clone the git repo and see to try pushing (again, I'm sure I tried before) the Gentoo-specific patches.
You can find two git branches for alsa-tools and alsa-utils at these addresses:
git://git.flameeyes.eu/others/alsa/alsa-tools.git git://git.flameeyes.eu/others/alsa/alsa-utils.git
For the patches coming from users, the proper Author setting was done so that they are reported coming from the correct contributor.
In commit de0aea763c5113f2373fc1cf6034b018d255bd94,
diff --git a/alsaconf/alsaconf.in b/alsaconf/alsaconf.in index 806ddb6..56f2a4b 100644 --- a/alsaconf/alsaconf.in +++ b/alsaconf/alsaconf.in @@ -908,13 +908,8 @@ BEGIN { in_sound=0; }
farewell clear
- if [ "$distribution" = "gentoo" ]; then
xecho "Running modules-update..."modules-update- elif [ "$distribution" = "debian" ]; then
xecho "Running update-modules..."update-modules- fi
- xecho "Running update-modules..."
- update-modules if [ -x $rcalsasound ] ; then
You unconditionally call update-modules, but this doesn't exist in all distros, but this is wrong. The world isn't ruled by only debian and gentoo :)
Check the availability before calling it.
Other changes in alsa-utils look OK.
thanks,
Takashi