17 Jan
2014
17 Jan
'14
7:48 p.m.
On Thu, Jan 16, 2014 at 10:52:35PM +0100, Lars-Peter Clausen wrote:
On 01/16/2014 09:44 AM, Xiubo Li wrote:
Makes the code slightly shorter
Signed-off-by: Xiubo Li Li.Xiubo@freescale.com
I don't like this. I don't think it is a good design pattern to call devm function from within (especial non-devm) library functions. It creates an asymmetric API. The memory is allocated when snd_dmaengine_pcm_register() is called, but it is not freed when snd_dmaengine_pcm_unregister() is called. This goes against the principle of least surprise.
Yes, I tend to agree - unless we only support managed registration the API shouldn't do managed things internally.